Back to Blocks

Claude Terminal

Loading...

Task Details
PXL-682Ready
Urgent

📊 Consistent calorie totals across all your devices

Estimate5 points
b2-heradatasync

What we're fixing:

After your meals sync between your iPhone, iPad, and Mac, the total calories for the day should be exactly the same on all devices. Currently, different devices can show different calorie totals for the same day—sometimes varying by several calories—and the numbers can even change when you swipe between days without making any edits. This task identifies why the day-level calorie calculation is inconsistent and ensures all devices show the same stable total after syncing.

Problem

After syncing meals and meal items between devices, the day's total energy value is inconsistent and unstable:

  • ●Different values on different devices: One device shows 7752 kcal, another shows 7759 kcal for the same day
  • ●Values changing without user action: Swiping the day back and forth caused the value to change: 7752 → 7758 → 7759 → 7754
  • ●Only affects energy: Macros and micros appear to be consistent across devices
  • ●Meal-level totals are correct: The nutrient bar in the meal headers shows the same values on both devices
Observations

What's Consistent

  • ●Individual meal energy values match between devices
  • ●Macro totals (protein, carbs, fat) are stable
  • ●Micro nutrient totals are stable
  • ●The issue only affects the day-level energy total

What's Inconsistent

  • ●Day-level total energy calculation
  • ●Value changes spontaneously when:
    • ●Swiping between days
    • ●Waiting a few moments
    • ●No user edits being made
Hypotheses

1. Rounding/Precision Issues

The energy total might be calculated differently in different places:

  • ●Summing meal energy values (already rounded)
  • ●Recalculating from macros (protein × 4 + carbs × 4 + fat × 9)
  • ●Different rounding strategies causing drift

2. Sync/State Management Race Condition

  • ●Background calculations updating while UI is refreshing
  • ●CoreData context conflicts between sync and UI layer
  • ●Cached values not being invalidated properly after sync

3. Macro-to-Energy Conversion Inconsistency

  • ●Some foods might store pre-calculated energy values
  • ●Others calculate energy from macros on-the-fly
  • ●Differences in which approach is used in different contexts

4. Incomplete Sync State

  • ●Some meal items might not be fully synced/hydrated
  • ●Related food data might be missing temporarily
  • ●Calculations might be running with incomplete data
Technical Context

Relevant Files to Investigate:

  • ●Day energy calculation logic
  • ●Meal item energy aggregation
  • ●Sync merge logic for meals/items
  • ●CoreData relationship loading (faulting issues?)

Questions to Answer:

  1. ●Where is day-level energy calculated? Multiple places?
  2. ●Is it stored or always calculated on-demand?
  3. ●How do we ensure all meal items are loaded when calculating?
  4. ●Are there any background recalculations that could cause UI updates?
Expected Behavior
  • ●Day-level energy total should be identical on all devices after sync completes
  • ●Value should be stable and not change unless user edits data
  • ●Calculation should be deterministic regardless of when/where it runs
  • ●Should match the sum of individual meal energy values shown in headers
Acceptance Criteria
  • ● Both devices show identical energy totals after sync (within 1 kcal tolerance for rounding)
  • ● Energy value remains stable when swiping between days
  • ● Energy value doesn't change spontaneously without user action
  • ● Day total matches sum of meal header values exactly
  • ● Root cause identified and documented
  • ● Fix verified across multiple sync scenarios
Impact

Severity: High - This affects the core accuracy of the app's primary metric User Trust: Users rely on these numbers for tracking; inconsistency erodes confidence Data Integrity: Suggests potential broader issues with sync or calculation logic

Comments (1)
Ahmed Khalaf
Ahmed KhalafJan 11, 2026, 4:06 AM

Implementation Summary

Issue 1: Inconsistent calorie totals across devices

Root Cause: When displaying a day, DayDTO.recalculateNutrientTotals() correctly calculates totals from meals, but the recalculated values were never saved back to the Day model in the database. This caused:

  • ●Different devices showing different values (each had different stale cached values)
  • ●Values changing when swiping between days (stale cache vs fresh calculation)
  • ●Sync pushing/pulling stale values

Fix in DayViewController.swift (lines 742-755):

// PXL-682: Save recalculated nutrient totals back to the Day model if they changed
let tolerance: Double = 0.01
let energyChanged = abs(fetchedDay.energyInKcal - dayDTO.energyInKcal) > tolerance
let carbChanged = abs(fetchedDay.carb - dayDTO.carb) > tolerance
let fatChanged = abs(fetchedDay.fat - dayDTO.fat) > tolerance
let proteinChanged = abs(fetchedDay.protein - dayDTO.protein) > tolerance

if energyChanged || carbChanged || fatChanged || proteinChanged {
    fetchedDay.setNutrientTotals(fromDTO: dayDTO)
    fetchedDay.markAsNeedingSync()
    try? context.save()
}

Issue 2: Meal item moves being reverted after sync

Root Cause: In SyncCoordinator.swift, after calling applyTo(existingItem), the code unconditionally re-linked the item to the remote's meal ID - even when applyTo had correctly skipped applying remote data due to local pending changes.

Fix in SupabaseConversions.swift:

  • ●SupabaseMealItem.applyTo() now returns Bool indicating whether remote data was applied

Fix in SyncCoordinator.swift (lines 1302-1329):

// PXL-682: applyTo now returns whether remote data was applied
let remoteDataApplied = remoteItem.applyTo(existingItem)

// PXL-682: ONLY re-link if remote data was applied, otherwise local mealID is preserved
// This prevents reverting meal item moves when the item has pending local changes
if remoteDataApplied {
    // ... re-link to remote's meal
}

Additional Improvement

In DayViewController.insertMeal() (lines 1686-1691):

  • ●When inserting a meal, update the day DTO's nutrient totals immediately
  • ●Ensures UI shows correct totals without waiting for refetch

Files Changed

  • ●NutriKit/Refactor Inbox/UIKit/DayViewController.swift
  • ●Packages/App/Sources/App/Supabase/SupabaseConversions.swift
  • ●Packages/App/Sources/App/Supabase/SyncCoordinator.swift

Expected Results

  • ●Day totals will be identical on all devices after sync
  • ●Values will remain stable when swiping between days
  • ●Day totals will match the sum of meal values exactly
  • ●Meal item moves are preserved and not reverted by sync
Created Dec 1, 2025, 6:01 PM | Updated Feb 6, 2026, 11:40 AM
Previous🏠 24/7 home server for food databasePXL-915
Next🔄 Keep meal UI state in sync during background updates (checkboxes, chevrons, expand/collapse)PXL-742